Skip to content

Use execve() to replace system() #4223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use execve() to replace system() #4223

wants to merge 1 commit into from

Conversation

lum1n0us
Copy link
Collaborator

  • Direct Execution: execve() directly executes a program, bypassing the shell. This avoids vulnerabilities like shell injection, which can occur with system() if user input is not properly sanitized.
  • Controlled Environment: With execve(), you can explicitly specify the environment variables for the new process, providing better control over the execution context.
  • No Shell Overhead: execve() does not invoke a shell, reducing the risk of unintended behavior caused by shell features or configurations.
  • Predictable Behavior: execve() only executes the specified program, whereas system() relies on the shell, which may interpret commands differently based on the shell's configuration or environment.

@lum1n0us lum1n0us force-pushed the fix/reimplement_bh_system branch 2 times, most recently from 36ffe27 to 55ad4b6 Compare April 28, 2025 03:35
yamt
yamt reviewed Apr 28, 2025
View reviewed changes
@lum1n0us lum1n0us force-pushed the fix/reimplement_bh_system branch from 55ad4b6 to d3a2cdd Compare April 29, 2025 05:31
@lum1n0us lum1n0us marked this pull request as draft May 6, 2025 02:38
@lum1n0us lum1n0us force-pushed the fix/reimplement_bh_system branch 2 times, most recently from 0860f09 to efdba17 Compare May 9, 2025 09:05
@lum1n0us
Use execve() to replace system() and rename to os_execve()
c1df02f 
- Direct Execution: execve() directly executes a program, bypassing the shell.
  This avoids vulnerabilities like shell injection, which can occur with
  system() if user input is not properly sanitized.
- Controlled Environment: With execve(), you can explicitly specify the
  environment variables for the new process, providing better control over
  the execution context.
- No Shell Overhead: execve() does not invoke a shell, reducing the risk
  of unintended behavior caused by shell features or configurations.
- Predictable Behavior: execve() only executes the specified program, whereas
  system() relies on the shell, which may interpret commands differently
  based on the shell's configuration or environment.
@lum1n0us lum1n0us force-pushed the fix/reimplement_bh_system branch from efdba17 to c1df02f Compare May 9, 2025 09:35
@lum1n0us lum1n0us marked this pull request as ready for review May 14, 2025 00:55
@lum1n0us lum1n0us mentioned this pull request May 19, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamt yamt yamt left review comments

@loganek loganek Awaiting requested review from loganek loganek is a code owner

@no1wudi no1wudi Awaiting requested review from no1wudi no1wudi is a code owner

@TianlongLiang TianlongLiang Awaiting requested review from TianlongLiang TianlongLiang is a code owner

@wenyongh wenyongh Awaiting requested review from wenyongh wenyongh is a code owner

@xujuntwt95329 xujuntwt95329 Awaiting requested review from xujuntwt95329 xujuntwt95329 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lum1n0us @yamt @xujuntwt95329